Skip to content

✨ Allocate dedicated host when a dedicated host doesn't exist #5631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2025
Merged

✨ Allocate dedicated host when a dedicated host doesn't exist #5631

merged 1 commit into from
Oct 30, 2025
+1,233 −39

Conversation

@rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Aug 26, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Builds on #5548 to enable CAPA to allocate a dedicated host. This removes the requirement that a dedicated host exist prior to instance provisioning. A core assumption of this PR is that there is a 1:1 mapping between an instance and the dedicated host on which it runs. Nothing in this implementation precludes scheduling multiple instances to a given dedicated host, but that is not the goal of this initial implementation.

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes emoji in title
  • adds unit tests

Release note:

Adds support for provisioning a new instance on a newly allocated dedicated host. The dedicate host is associated only with the new instance.  When the instance is deprovisioned, the dedicated host will be released as well.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 26, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2025
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 2 times, most recently from 0cadb9a to 2dd765e Compare August 27, 2025 13:54
@punkwalker
Copy link
Contributor

punkwalker commented Aug 27, 2025 •
edited
Loading

Hi @rvanderp3,
Thank you for picking this up.
I know the PR is still in draft but I wanted to add some suggestion at the start. Hope you don't mind.

punkwalker
punkwalker reviewed Aug 27, 2025
View reviewed changes
@rvanderp3
Copy link
Contributor Author

Hi @rvanderp3, Thank you for picking this up. I know the PR is still in draft but I wanted to add some suggestion at the start. Hope you don't mind.

not at all, I appreciate the early feedback

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from 2dd765e to 92e2a20 Compare August 27, 2025 20:31
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
@enxebre
Copy link
Member

enxebre commented Aug 28, 2025

covers #5599

@enxebre
Copy link
Member

enxebre commented Aug 28, 2025

@rvanderp3 thanks! this is looking great. I dropped some early feedback.

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 3 times, most recently from c46e590 to e58d9fb Compare August 28, 2025 20:28
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 93a56269d2647669a2b4fec8383b7eae75f2c93b

@mtulio
Copy link
Contributor

mtulio commented Oct 23, 2025 •
edited
Loading

Thanks for addressing the comments, @rvanderp3 ! This looks good to me! 👍🏽

/lgtm

@rvanderp3 nit: you may need to squash the commits :)

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from d4f729d to 5acede4 Compare October 23, 2025 19:15
@rvanderp3
Copy link
Contributor Author

Thanks for addressing the comments, @rvanderp3 ! This looks good to me! 👍🏽
/lgtm

@rvanderp3 nit: you may need to squash the commits :)

good point. done!

@mtulio
Copy link
Contributor

mtulio commented Oct 23, 2025

/lgtm

@rvanderp3
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e-blocking

@rvanderp3
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2025
@rvanderp3
Copy link
Contributor Author

/assign @punkwalker

nrb
nrb reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this lgtm, there's one minor but important comment I have on the field documentation.

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from 5acede4 to 7ac683c Compare October 30, 2025 17:57
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

@rvanderp3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-apidiff-main 7ac683c link false /test pull-cluster-api-provider-aws-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nrb
Copy link
Contributor

nrb commented Oct 30, 2025

The apidiff failure is fine, just letting us know that a Go-level API was changed. Since it's additive here, I see no issue.

@nrb
Copy link
Contributor

nrb commented Oct 30, 2025

/lgtm
/approve

Doing both since the last edit was just updating a comment.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4260f1220aac12a4de0afec525e89b10f1def05c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@rvanderp3
Copy link
Contributor Author

/release-note-edit

Adds support for provisioning a new instance on a newly allocated dedicated host. The dedicate host is associated only with the new instance. When the instance is deprovisioned, the dedicated host will be released as well.

@k8s-ci-robot
Copy link
Contributor

@rvanderp3: /release-note-edit must be used with a single release note block.

In response to this:

/release-note-edit

Adds support for provisioning a new instance on a newly allocated dedicated host. The dedicate host is associated only with the new instance. When the instance is deprovisioned, the dedicated host will be released as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit 26bbb03 into kubernetes-sigs:main Oct 30, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo Awaiting requested review from damdo

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

@faiq faiq Awaiting requested review from faiq

@mtulio mtulio Awaiting requested review from mtulio

@nrb nrb Awaiting requested review from nrb

@punkwalker punkwalker Awaiting requested review from punkwalker

1 more reviewer

@enxebre enxebre enxebre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nrb nrb

@mtulio mtulio

@damdo damdo

@punkwalker punkwalker

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rvanderp3 @k8s-ci-robot @punkwalker @enxebre @damdo @mtulio @nrb